custom font to render clock applet #1358
Conversation
use custom font to render clock applet. configuration is available via gsettings/dconf-editor
There was a problem hiding this comment.
I got this to build and run fine, but on killing the panel (so it could restart) and running my older version dconf-editor 3.18 I was not able to find any references to the clock schema (a relocatable one?) so wondering if this may depend on
#1355
to actually work. Will apply that on top of this change and see what happens
|
The changes here did not show up in dconf-editor after applying Due to the relocatable schema issue, this might be more useful if custom formats can be applied from the clock preferences dialog as well |
|
Why do we need "use-custom-font" setting? If "custom-font" is left default ("Use default value" ON), custom font is not in use. If we turn it OFF and enter custom font, we use that one instead. I find this setting redundant, and even potentially misleading (as one is on top of the window, and another one at the bottom - so one can easily miss the bottom "use-custom-font" setting, believing custom font is chosen already by setting "custom-font"). I support the idea of custom font through the clock preferences dialog (possibly with a selectable list of fonts installed instead of text window). |
| " padding-top: 0px;\n" | ||
| " padding-bottom: 0px;\n" | ||
| " padding-left: 0px;\n" | ||
| " padding-right: 0px;\n" |
There was a problem hiding this comment.
Why removing the padding for vertical panels?
I can't recall but there was a reason why we use the padding, many years ago.
For me it looks nicer with a padding. Using 2px seems OK for me.
Any way, i don't want to block it.
But this needs to be moved in a single commit.
Otherwise you will never find the change in git history, when user will blame us about.
There was a problem hiding this comment.
And why adding the 2 blanks before padding-......?
|
It works on my box but having 2 gsettings keys for the same setting seems to be overloaded. |
|
What is the status of this? |
use custom font to render clock applet.
configuration is available via gsettings/dconf-editor
example how it looks with vertical panel (panel width: 44, font:8 "DejaVu Sans", format: '24-hour'):
can be helpful for #1090 and #157